Support ext-workspace-v1
#1213
Support ext-workspace-v1
#1213
Conversation
|
Looks good on first read apart from the lack of testing obviously. Seems like a good approach to me. |
|
I guess one thing I'm missing here is sending We can do the same for now, sending |
|
After updating pop-os/cosmic-protocols#51 with cctk changes, and sending |
To support both `ext-workspace-v1` and `cosmic-workspace-unstable-v1`, the API exposed by `wayland/protocols/workspace` now uses the ext workspace `State` and `GroupCapabilties` bitfields, and converts them to the cosmic types for the cosmic implementation. `WorkspaceCapabilities` is a custom type that has cosmic-specific and ext-specific variants, and is mapped on both backends. The ext protocol adds an `.assign` request on workspaces, which is added here, though not currently used. It also adds an `.id` event. Which we'll probably want when we have persistent workspaces, but it isn't needed currently. We still need to add an extension protocol of ext-workspaces to replace a couple cosmic protocol features.
ids1024
force-pushed
the
ext-workspace
branch
from
7aa4c32 to
5b79f8e
Compare
|
Oh, I guess I still need to make sure it sends (Relatedly, this needs a fix like #1061. I guess we don't currently have any clients that end up binding the workspaces protocol in two places.) |
Similarly to #1061, track a weak reference to the manager each workspace/group instance was created from, instead of just matching by client.
This should work, though I still need to test with a client.
This doesn't yet add an extension protocol (pop-os/cosmic-protocols#51). We could merge this without that (after some testing) but we'll want to add that soon.