Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criando quadro de aulas #154

Closed
wants to merge 1 commit into from
Closed

Conversation

williamsla
Copy link
Contributor

Corrigindo erro genérico ao criar quadro de aulas

Descrição

Ao tentar criar um novo quadro de aulas estava aparecendo a mensagem de erro genérico

Contexto e motivação

Corrigindo a forma de acessar o objeto classrroms_grade

Tipos de alterações

  • ✅ Correção de bugs (Não quebra outras funcionalidades)

Checklist:

  • ✅ Eu li o documento CONTRIBUTING. [REQUIRED]
  • ✅ Meu código segue o style guide. [REQUIRED]
  • ✅ Todos os testes novos e existentes estão passando. [REQUIRED]

Corrigindo erro genérico ao criar quadro de aulas
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

5.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@msoares94
Copy link
Contributor

@edersoares, realizei o teste tando na versão 1.4 do i-Diário quanto na 1.5 e o PR corrigi o problema!

@williamsla, show de bola meu caro, parabéns pela contribuição!

<% else %>
<%= f.input :unity, label: t('lessons_boards.index.unity'), placeholder: t('lessons_boards.index.unity'), readonly: true, input_html: { value: f.object.classroom.unity.name }, required: true %>
<%= f.input :unity, label: t('lessons_boards.index.unity'), placeholder: t('lessons_boards.index.unity'), readonly: true, input_html: { value: f.object.classrooms_grade.classroom.unity.name }, required: true %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esse ponto faz sentido pra mim

@@ -8,9 +8,9 @@
<div class="col col-sm-3">
<% if action_name == "new" %>
<%= f.input :unity, as: :select2, elements: unities, hide_empty_element: true, label: t('lessons_boards.index.unity'),
placeholder: t('lessons_boards.index.unity'), readonly: !can_change_unity?, input_html: { value: !can_change_unity? ? unities.first.id : '' }, required: true %>
placeholder: t('lessons_boards.index.unity'), readonly: false, input_html: { value: unities.first.id }, required: true %>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esse impacta na usabilidade da tela, não? @AnaPerola @Dmadaschi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edersoares a variável can_change_unity não foi definida no código-fonte do projeto.

Copy link
Contributor

@AnaPerola AnaPerola Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edersoares @williamsla Esse ajuste já está passando pelos processos internos da Portabilis. Realmente a can_change_unity não foi definida aqui nesse projeto.

@AnaPerola
Copy link
Contributor

Olá pessoal,

Agradeço a contribuição @williamsla, irei apenas encerrar esse PR pois já inserimos esse ajuste e está disponível aqui

🚀

@AnaPerola AnaPerola closed this Jun 19, 2024
@williamsla williamsla deleted the patch-3 branch September 1, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants