Skip to content

Commit

Permalink
Address ApiClient Bullet warnings & refactor
Browse files Browse the repository at this point in the history
- Resolves the following N+1 Bullet warning that was being triggered by both of these updated controllers:
```
USE eager loading detected
  ApiClient => [:org]
  Add to your query: .includes([:org])
Call stack
  /home/aaron/Documents/GitHub/roadmap/app/views/paginable/api_clients/_index.html.erb:27:in `block in _app_views_paginable_api_clients__index_html_erb___600648306456484266_76960'
  /home/aaron/Documents/GitHub/roadmap/app/views/paginable/api_clients/_index.html.erb:24:in `_app_views_paginable_api_clients__index_html_erb___600648306456484266_76960'
  /home/aaron/Documents/GitHub/roadmap/app/controllers/concerns/paginable.rb:85:in `paginable_renderise'
  /home/aaron/Documents/GitHub/roadmap/app/views/super_admin/api_clients/index.html.erb:16:in `_app_views_super_admin_api_clients_index_html_erb__3604505130684601528_76940'
```
- Additionally, `ApiClient.includes(:org).all.page(1)` appears to be redundant, so it has been refactored to `ApiClient.includes(:org).page(1)`.
  • Loading branch information
aaronskiba committed Feb 11, 2025
1 parent 5d5ddc6 commit 60afc51
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/controllers/paginable/api_clients_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class ApiClientsController < ApplicationController
# GET /paginable/api_clients
def index
authorize(ApiClient)
@api_clients = ApiClient.all
@api_clients = ApiClient.includes(:org).all

paginable_renderise(
partial: 'index',
Expand Down
2 changes: 1 addition & 1 deletion app/controllers/super_admin/api_clients_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class ApiClientsController < ApplicationController
# GET /api_clients
def index
authorize(ApiClient)
@api_clients = ApiClient.all.page(1)
@api_clients = ApiClient.includes(:org).page(1)
end

# GET /api_clients/new
Expand Down

0 comments on commit 60afc51

Please sign in to comment.