Skip to content

Commit

Permalink
e2e-test: organize session code together (#6457)
Browse files Browse the repository at this point in the history
### Summary
Re-organizing the session code. There should be no functional change. It
was just getting gnarly with having console & sessions together in same
file.

### QA Notes

@:sessions
  • Loading branch information
midleman authored Feb 24, 2025
1 parent bd2d2d3 commit 7ed563a
Show file tree
Hide file tree
Showing 7 changed files with 642 additions and 625 deletions.
162 changes: 0 additions & 162 deletions test/e2e/infra/fixtures/interpreter-new.ts

This file was deleted.

2 changes: 1 addition & 1 deletion test/e2e/infra/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ export * from '../pages/debug';
export * from '../pages/problems';
export * from '../pages/references';
export * from '../pages/scm';
export * from '../pages/sessions';

// fixtures
export * from './fixtures/userSettings';
export * from './fixtures/interpreter-new';

// test-runner
export * from './test-runner';
Expand Down
8 changes: 4 additions & 4 deletions test/e2e/infra/workbench.ts
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ import { EditorActionBar } from '../pages/editorActionBar';
import { Problems } from '../pages/problems';
import { References } from '../pages/references';
import { SCM } from '../pages/scm';
import { InterpreterNew } from './fixtures/interpreter-new';
import { Sessions } from '../pages/sessions';

export interface Commands {
runCommand(command: string, options?: { exactLabelMatch?: boolean }): Promise<any>;
Expand All @@ -45,7 +45,6 @@ export interface Commands {
export class Workbench {

readonly interpreter: Interpreter;
readonly interpreterNew: InterpreterNew;
readonly popups: Popups;
readonly console: Console;
readonly variables: Variables;
Expand Down Expand Up @@ -77,6 +76,7 @@ export class Workbench {
readonly problems: Problems;
readonly references: References;
readonly scm: SCM;
readonly sessions: Sessions;

constructor(code: Code) {

Expand All @@ -95,8 +95,7 @@ export class Workbench {
this.connections = new Connections(code, this.quickaccess);
this.newProjectWizard = new NewProjectWizard(code, this.quickaccess);
this.output = new Output(code, this.quickaccess, this.quickInput);
this.interpreterNew = new InterpreterNew(code);
this.console = new Console(code, this.quickaccess, this.quickInput, this.interpreterNew);
this.console = new Console(code, this.quickaccess, this.quickInput);
this.interpreter = new Interpreter(code, this.console);
this.notebooks = new Notebooks(code, this.quickInput, this.quickaccess);
this.welcome = new Welcome(code);
Expand All @@ -113,5 +112,6 @@ export class Workbench {
this.problems = new Problems(code, this.quickaccess);
this.references = new References(code);
this.scm = new SCM(code, this.layouts);
this.sessions = new Sessions(code, this.console, this.quickaccess, this.quickInput);
}
}
Loading

0 comments on commit 7ed563a

Please sign in to comment.