Skip to content

Commit

Permalink
Temporarily restrict get_column_profiles to only return ColumnProfile…
Browse files Browse the repository at this point in the history
…Type.NullCount (#3499)
  • Loading branch information
softwarenerd authored Jun 12, 2024
1 parent 8173d66 commit cdffd4e
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1284,7 +1284,10 @@ def _prof_histogram(self, column_index: int):
supported=True,
supported_types=[
ColumnProfileType.NullCount,
ColumnProfileType.SummaryStats,
# Temporarily disabled for https://github.com/posit-dev/positron/issues/3490
# on 6/11/2024. This will be enabled again when the UI has been reworked to
# more fully support column profiles.
# ColumnProfileType.SummaryStats,
],
),
set_sort_columns=SetSortColumnsFeatures(supported=True),
Expand Down Expand Up @@ -1575,7 +1578,13 @@ def _prof_histogram(self, column_index: int) -> ColumnHistogram:
),
get_column_profiles=GetColumnProfilesFeatures(
supported=True,
supported_types=[ColumnProfileType.NullCount],
supported_types=[
ColumnProfileType.NullCount,
# Temporarily disabled for https://github.com/posit-dev/positron/issues/3490
# on 6/11/2024. This will be enabled again when the UI has been reworked to
# more fully support column profiles.
# ColumnProfileType.SummaryStats,
],
),
export_data_selection=ExportDataSelectionFeatures(supported=False),
set_sort_columns=SetSortColumnsFeatures(supported=False),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,10 @@ def test_pandas_supported_features(dxf: DataExplorerFixture):
assert column_profiles["supported"]
assert set(column_profiles["supported_types"]) == {
"null_count",
"summary_stats",
# Temporarily disabled for https://github.com/posit-dev/positron/issues/3490
# on 6/11/2024. This will be enabled again when the UI has been reworked to
# more fully support column profiles.
# "summary_stats",
}


Expand Down

0 comments on commit cdffd4e

Please sign in to comment.