Skip to content

Commit

Permalink
Compare build numbers (#6011)
Browse files Browse the repository at this point in the history
Fix build number comparison when checking for updates
  • Loading branch information
timtmok authored Jan 16, 2025
1 parent 202cbd1 commit e334f8e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/vs/platform/update/electron-main/abstractUpdateService.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,11 +198,11 @@ export abstract class AbstractUpdateService implements IUpdateService {
return Promise.resolve(null);
}

if (hasUpdate(update, this.productService.positronVersion)) {
if (hasUpdate(update, `${this.productService.positronVersion}-${this.productService.positronBuildNumber}`)) {
this.logService.info(`update#checkForUpdates, ${update.version} is available`);
this.updateAvailable(update);
} else {
this.logService.info(`update#checkForUpdates, ${this.productService.positronVersion} is the latest version`);
this.logService.info(`update#checkForUpdates, ${this.productService.positronVersion}-${this.productService.positronBuildNumber} is the latest version`);
this.setState(State.Idle(this.getUpdateType()));
}
return Promise.resolve(update);
Expand Down

0 comments on commit e334f8e

Please sign in to comment.