Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prerelease branched to merge workflow #5388

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

jonvanausdeln
Copy link
Contributor

Intent

Similar to #5352, we should run full test suite when merging to prerelease branches. This will help with catching issues when we aren't running the nightly full tests against the branch.

QA Notes

Tests run when merging to prerelease branch. This will be hard to test until a change to a prerelease branch is made.

Copy link
Member

@sharon-wang sharon-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on renaming this workflow file to positron-merge-to-branch.yml now that it applies to any specified branches? We'd need to fix a reference to this file in .github/workflows/positron-pull-requests.yml if we go ahead with the rename. Not sure if there may be other places we'd want to update the filename?

For testing the changes, I had to backport the PR CI change to the prerelease/2024.11 branch in order for the CI changes to run against that branch. I'm going to backport #5352 to the other prerelease branches shortly.

We'll need to backport this PR to the prerelease branches too. The good news is that we'll be able to see if the merge to the prerelease branches kicks off the workflow right away!

@sharon-wang sharon-wang self-requested a review November 18, 2024 16:24
@jonvanausdeln jonvanausdeln merged commit c6b91c2 into main Nov 18, 2024
3 checks passed
@jonvanausdeln jonvanausdeln deleted the jonv-add-prelease-merge-tests branch November 18, 2024 18:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2024
@sharon-wang
Copy link
Member

Backporting this change to the prerelease branches:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants