E2E test: Allow for web only test cases #6353
Merged
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
testlabauto
changed the title
midleman
reviewed
Feb 19, 2025
| DISPLAY=:10 npx playwright test --project ${{ inputs.project }} --workers 2 --grep "${{ env.PW_TAGS }}" --repeat-each ${{ inputs.repeat_each }} --max-failures 10 | ||
| if [ "${{ inputs.project }}" == "e2e-electron" ]; then | ||
| DISPLAY=:10 npx playwright test --project ${{ inputs.project }} --workers 2 --grep "${{ env.PW_TAGS }}" --grep-invert @:web-only --repeat-each ${{ inputs.repeat_each }} --max-failures 10 | ||
| else |
There was a problem hiding this comment.
its for e2e-browser. on electron, we need the invert. on browser we don't
| @@ -48,6 +48,7 @@ export enum TestTags { | |||
| TEST_EXPLORER = '@:test-explorer', | |||
| TOP_ACTION_BAR = '@:top-action-bar', | |||
| VARIABLES = '@:variables', | |||
| WEB_ONLY = '@:web-only', | |||
There was a problem hiding this comment.
Nit: Could you add this under the platform tags section/comment instead (since it's not a feature flag)?
testlabauto
commented
Feb 19, 2025
| DISPLAY=:10 npx playwright test --project ${{ inputs.project }} --workers 2 --grep "${{ env.PW_TAGS }}" --repeat-each ${{ inputs.repeat_each }} --max-failures 10 | ||
| if [ "${{ inputs.project }}" == "e2e-electron" ]; then | ||
| DISPLAY=:10 npx playwright test --project ${{ inputs.project }} --workers 2 --grep "${{ env.PW_TAGS }}" --grep-invert @:web-only --repeat-each ${{ inputs.repeat_each }} --max-failures 10 | ||
| else |
There was a problem hiding this comment.
its for e2e-browser. on electron, we need the invert. on browser we don't
midleman
approved these changes
Feb 19, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--grep-invert for web only cases
QA Notes
All tests should pass
@:reticulate @:web