Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e-test: fix locator on plots test #6396

Merged
merged 2 commits into from
Feb 19, 2025
Merged

e2e-test: fix locator on plots test #6396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f19776
update locator
midleman Feb 19, 2025
6920f4d
remove unused
midleman Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions test/e2e/pages/plots.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ const PREVIOUS_PLOT_BUTTON = '.positron-plots-container .positron-action-bar .po
const CLEAR_PLOTS_BUTTON = '.positron-plots-container .positron-action-bar .positron-button[aria-label="Clear all plots"]';
const PLOT_SIZE_BUTTON = '.positron-plots-container .positron-action-bar .positron-button[aria-label="Auto"]';
const SAVE_PLOT_FROM_PLOTS_PANE_BUTTON = '.positron-plots-container .positron-action-bar .positron-button[aria-label="Save plot"]';
const SAVE_PLOT_FROM_EDITOR_BUTTON = '.editor-actions .codicon-positron-save';
const COPY_PLOT_BUTTON = '.positron-plots-container .positron-action-bar .positron-button[aria-label="Copy plot to clipboard"]';
const ZOOM_PLOT_BUTTON = '.positron-plots-container .positron-action-bar .positron-button[aria-label="Fit"]';
const OUTER_WEBVIEW_FRAME = '.webview';
Expand Down Expand Up @@ -45,7 +44,7 @@ export class Plots {
this.clearPlotsButton = this.code.driver.page.locator(CLEAR_PLOTS_BUTTON);
this.plotSizeButton = this.code.driver.page.locator(PLOT_SIZE_BUTTON);
this.savePlotFromPlotsPaneButton = this.code.driver.page.locator(SAVE_PLOT_FROM_PLOTS_PANE_BUTTON);
this.savePlotFromEditorButton = this.code.driver.page.locator(SAVE_PLOT_FROM_EDITOR_BUTTON);
this.savePlotFromEditorButton = this.code.driver.page.getByRole('button', { name: 'Save Plot From Active Editor' });
this.copyPlotButton = this.code.driver.page.locator(COPY_PLOT_BUTTON);
this.zoomPlotButton = this.code.driver.page.locator(ZOOM_PLOT_BUTTON);
this.currentPlot = this.code.driver.page.locator(CURRENT_PLOT);
Expand Down