Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Multiple Console Sessions Feature Flag for Web #6410

Merged
merged 5 commits into from
Feb 21, 2025

Conversation

dhruvisompura
Copy link
Contributor

@dhruvisompura dhruvisompura commented Feb 20, 2025

Release Notes

Addresses #6401

The configuration scope for console.multipleConsoleSessions was set to MACHINE_OVERRIDABLE which prevented enabling the feature flag as a user setting in the Web build of Positron.

We do not require this scope so it has been removed and allows the feature flag to be enabled which unblcosk CI testing for this new feature!

New Features

  • N/A

Bug Fixes

  • N/A

QA Notes

@:sessions @:web @:win

Copy link

github-actions bot commented Feb 20, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:sessions @:web @:win

readme  valid tags

softwarenerd
softwarenerd previously approved these changes Feb 20, 2025
Copy link
Contributor

@softwarenerd softwarenerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

Copy link
Contributor

@midleman midleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are now passing. 🚀

@dhruvisompura dhruvisompura merged commit 52583c7 into main Feb 21, 2025
8 checks passed
@dhruvisompura dhruvisompura deleted the bugfix/multiple-console-ff-for-web branch February 21, 2025 02:03
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants