Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix modal popup layout and scrolling #6413

Merged
merged 11 commits into from
Feb 21, 2025

Conversation

softwarenerd
Copy link
Contributor

@softwarenerd softwarenerd commented Feb 20, 2025

Description

This PR addresses #3061 by updating how modal popups are laid out.

Tests:
@:data-explorer
@:new-project-wizard

Release Notes

New Features

  • N/A

Bug Fixes

QA Notes

We will need to think about how we can test this code in an end-to-end test.

Copy link

github-actions bot commented Feb 20, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:data-explorer @:new-project-wizard

readme  valid tags

sharon-wang
sharon-wang previously approved these changes Feb 21, 2025
Copy link
Member

@sharon-wang sharon-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well for me locally in the Project Wizard and the Data Explorer filters 🙌

Could we also run the @:new-project-wizard tests as well?

Otherwise just some minor comments and LGTM!

sharon-wang
sharon-wang previously approved these changes Feb 21, 2025
Copy link
Member

@sharon-wang sharon-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI! ✅

Copy link
Contributor

@dhruvisompura dhruvisompura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changed worked for the console info panel! There was some scenarios for small widths that caused the popup to get cut off but I think that has to do with the anchor point for the popup getting cut off and not scaling. Overall a much better improvement than what we had before.

I did have a comment and a couple questions but overall looks great!

@softwarenerd
Copy link
Contributor Author

This changed worked for the console info panel! There was some scenarios for small widths that caused the popup to get cut off but I think that has to do with the anchor point for the popup getting cut off and not scaling. Overall a much better improvement than what we had before.

I did have a comment and a couple questions but overall looks great!

This PR dealt almost exclusively with vertical layout and vertical scrolling, which is where the major problems of #3061 were to be found. I still have to deal with horizontal layout issues. I was not able to do this work in this PR because it was time-boxed for this milestone.

@softwarenerd softwarenerd merged commit 08c85ea into main Feb 21, 2025
8 checks passed
@softwarenerd softwarenerd deleted the fix/column-selector-modal-popup-scrolling branch February 21, 2025 22:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants