-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix modal popup layout and scrolling #6413
Fix modal popup layout and scrolling #6413
Conversation
E2E Tests 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working well for me locally in the Project Wizard and the Data Explorer filters 🙌
Could we also run the @:new-project-wizard
tests as well?
Otherwise just some minor comments and LGTM!
...rerPanel/components/addEditRowFilterModalPopup/components/columnSelectorDataGridInstance.tsx
Outdated
Show resolved
Hide resolved
src/vs/workbench/browser/positronComponents/positronModalPopup/positronModalPopup.tsx
Outdated
Show resolved
Hide resolved
...aExplorerPanel/components/addEditRowFilterModalPopup/components/columnSelectorModalPopup.tsx
Outdated
Show resolved
Hide resolved
...rerPanel/components/addEditRowFilterModalPopup/components/columnSelectorDataGridInstance.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending CI! ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changed worked for the console info panel! There was some scenarios for small widths that caused the popup to get cut off but I think that has to do with the anchor point for the popup getting cut off and not scaling. Overall a much better improvement than what we had before.
I did have a comment and a couple questions but overall looks great!
src/vs/workbench/browser/positronComponents/positronModalPopup/positronModalPopup.tsx
Outdated
Show resolved
Hide resolved
...aExplorerPanel/components/addEditRowFilterModalPopup/components/columnSelectorModalPopup.tsx
Outdated
Show resolved
Hide resolved
src/vs/workbench/browser/positronComponents/positronModalPopup/positronModalPopup.tsx
Outdated
Show resolved
Hide resolved
This PR dealt almost exclusively with vertical layout and vertical scrolling, which is where the major problems of #3061 were to be found. I still have to deal with horizontal layout issues. I was not able to do this work in this PR because it was time-boxed for this milestone. |
Description
This PR addresses #3061 by updating how modal popups are laid out.
Tests:
@:data-explorer
@:new-project-wizard
Release Notes
New Features
Bug Fixes
QA Notes
We will need to think about how we can test this code in an end-to-end test.