Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve working directory across restarts #6416

Merged
merged 9 commits into from
Feb 21, 2025
Merged

Conversation

jmcphers
Copy link
Collaborator

This change allows the working directory to persist across restarts, so that after a restart you don't need to re-navigate.

image

Most of the work is in the supervisor; this is just the client bits. I would have preferred for this change to only exist in the supervisor, but it turned out that on Windows there is no way to examine another process's current working directory if it has been changed, so the supervisor actually has no visibility into the working directory without trying to sniff the UI comm traffic or something equally dreadful.

Since we already plumb the working directory into the front end in order to display it in the Console, the approach taken here is to have the front end tell the supervisor the directory in which to perform the restart, since it already knows it.

Addresses #3188.

Release Notes

New Features

Bug Fixes

  • N/A

QA Notes

This should be tested on Windows because (predictably) it is the platform on which we have to do the most gymnastics to get this to work.

Copy link

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

@jmcphers jmcphers requested a review from seeM February 20, 2025 22:34
Copy link
Contributor

@seeM seeM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice! Works well locally and code changes look good

@jmcphers jmcphers merged commit 6403307 into main Feb 21, 2025
28 checks passed
@jmcphers jmcphers deleted the feature/working-dir-restart branch February 21, 2025 17:23
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants