Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E test: disable currents reporting for PRs #6429

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

testlabauto
Copy link
Contributor

@testlabauto testlabauto commented Feb 21, 2025

Our usage of currents.dev has been trending too high for what we planned to pay (pricing is a function of tests reported). Therefore, we are going to stop reporting to currents.dev for PR runs.

QA Notes

PR runs should not be reported to currents.

@:web @:win

Copy link

github-actions bot commented Feb 21, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:web @:win

readme  valid tags

Copy link
Contributor

@jonvanausdeln jonvanausdeln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great Job!

Copy link
Contributor

@midleman midleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great with one minor comment! 🚀

@@ -33,6 +33,11 @@ on:
description: "Whether or not to report results to TestRail."
default: false
type: boolean
enable_currents_reporter:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nit. but to be consistent with other params, might i suggest: report_currents

@testlabauto testlabauto merged commit 9399d25 into main Feb 21, 2025
15 checks passed
@testlabauto testlabauto deleted the cmead/reduce-currents-usage branch February 21, 2025 19:53
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants