Fix Python completions in Quarto #6471
Merged
+21
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
petetronic
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Confirmed locally that Python code cells in .qmd files now return completions, including the case that the user reported issue noted in #6444
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quarto converts ranges to/from the Python language server (source). The problem is that Quarto wasn't converting the
vscode.CompletionItem.textEditproperty if present, which we started using in #6002.Quarto may want to also fix on their side to support
textEdit. I think the reason they don't is because it's deprecated, but other language servers may use it too.I've made the fix (#6471) on our side too since it is a deprecated property. Would've avoided using it to begin with, but there unfortunately wasn't any deprecation note in the Python completion type.
Addresses #6444.
Release Notes
New Features
Bug Fixes