Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept k8s version to build node images #35

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

kishen-v
Copy link
Collaborator

@kishen-v kishen-v commented Jul 15, 2024

Changes:

  1. Accept version of k8s as an input to the workflow to build kind-node images.
  2. Refer to vars.QUAY_USERNAME from the earlier secrets.QUAY_USERNAME (requires changes in the repository setting to have this variable defined)

The docker workflow tends to fail as k8s-version is defaulting to null rather than master. However, subsequent builds seem to run fine.

##[debug]Evaluating: format('Build kind-node image - {0}', inputs.k8s-version)
[50](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:54)
##[debug]Evaluating format:
[51](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:55)
##[debug]..Evaluating String:
[52](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:56)
##[debug]..=> 'Build kind-node image - {0}'
[53](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:57)
##[debug]..Evaluating Index:
[54](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:58)
##[debug]....Evaluating inputs:
[55](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:59)
##[debug]....=> Object
[56](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:60)
##[debug]....Evaluating String:
[57](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:61)
##[debug]....=> 'k8s-version'
[58](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:62)
##[debug]..=> null.   <--------------------
[59](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:63)
##[debug]=> 'Build kind-node image - '
[60](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:64)
##[debug]Result: 'Build kind-node image - '
[61](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:65)
##[debug]Set step '__run_3' display name to: 'Build kind-node image - '
[62](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:66)
##[debug]Set step '__run_4' display name to: 'Publish node image'
[63](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:67)
Complete job name: build
[64](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:68)
##[debug]Collect running processes for tracking orphan processes.
[65](https://github.com/kishen-v/kind-image/actions/runs/9937700804/job/27450385411#step:1:69)
##[debug]Finishing: Set up job

vs.

##[debug]Evaluating format:
[51](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:55)
##[debug]..Evaluating String:
[52](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:56)
##[debug]..=> 'Build kind-node image - {0}'
[53](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:57)
##[debug]..Evaluating Index:
[54](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:58)
##[debug]....Evaluating inputs:
[55](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:59)
##[debug]....=> Object
[56](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:60)
##[debug]....Evaluating String:
[57](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:61)
##[debug]....=> 'k8s-version'
[58](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:62)
##[debug]..=> 'master' <------------
[59](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:63)
##[debug]=> 'Build kind-node image - master'
[60](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:64)
##[debug]Result: 'Build kind-node image - master'
[61](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:65)
##[debug]Set step '__run_3' display name to: 'Build kind-node image - master'
[62](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:66)
##[debug]Set step '__run_4' display name to: 'Publish node image'
[63](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:67)
Complete job name: build
[64](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:68)
##[debug]Collect running processes for tracking orphan processes.
[65](https://github.com/kishen-v/kind-image/actions/runs/9938312957/job/27450516466#step:1:69)
##[debug]Finishing: Set up job
image

@kishen-v kishen-v changed the title Accept k8s version to build node images [WIP]Accept k8s version to build node images Jul 15, 2024
@kishen-v kishen-v force-pushed the ip-version branch 3 times, most recently from e67f88e to 164b30b Compare July 15, 2024 14:28
@kishen-v kishen-v changed the title [WIP]Accept k8s version to build node images Accept k8s version to build node images Jul 15, 2024
.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
@mkumatag
Copy link
Member

@kishen-v I made as an admin to this repo, you can add the required variables in the settings section and also build is failing in the CI, please check..

Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope this PR is ready for the merge!

.github/workflows/docker-publish.yml Outdated Show resolved Hide resolved
Copy link
Member

@mkumatag mkumatag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ppc64le-cloud-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kishen-v, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ppc64le-cloud-bot ppc64le-cloud-bot merged commit d238857 into ppc64le-cloud:main Jul 30, 2024
2 checks passed
@kishen-v kishen-v deleted the ip-version branch August 1, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants