-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept k8s version to build node images #35
Conversation
e67f88e
to
164b30b
Compare
@kishen-v I made as an admin to this repo, you can add the required variables in the settings section and also build is failing in the CI, please check.. |
0f78315
to
809af92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hope this PR is ready for the merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishen-v, mkumatag The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes:
vars.QUAY_USERNAME
from the earliersecrets.QUAY_USERNAME
(requires changes in the repository setting to have this variable defined)The docker workflow tends to fail as k8s-version is defaulting to
null
rather thanmaster
. However, subsequent builds seem to run fine.vs.