Abort installation if version is Python 3 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @microamp, Yeah, this PR is right way to divert If we merge this without checking this out for older Python versions, this will be a wrong thing, I think. |
|
Hi @pravj, My apologies on my late reply. What Python 2 versions are you targetting apart from Python 2.7? So far, I've only tested it with 2.7 personally. I guess having a test suite would make things easier (CI (e.g. Travis) with the versions to support specified) although I'm not sure how trivial to write them for this particular application. Are you planning to write one in the near future? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops the installation process from proceeding if the version is Python 3 (which is not currently supported) as discussed in #4.
In addition to the above, I've added 'classifiers' (note that Python 3 is omitted there). Fee free to expand the list if you'd like it to support versions prior to 2.7.