-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attekmi: add Addigi adapter #5836
base: master
Are you sure you want to change the base?
Attekmi: add Addigi adapter #5836
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| Name | Scope | Description | Example | Type | | ||
|---------------|----------|---------------------|--------------------------------------|----------| | ||
| `seat` | required | Seat value | `'9Q20EdGxzgWdfPYShScl'` | `string` | | ||
| `token` | required | Token | `'eKmw6alpP3zWQhRCe3flOpz0wpuwRFjW'` | `string` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The adapter being aliased also requires partnerName. Please include that as a required field for Prebid Server Bid Params section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to use this parameter. We have foreseen this case.
When the partner will use this adapter, the value of partnerName will be substituted from the code, this should work on Prebid.js and Prebid-server sides
prebid.js will be work correct if partnerName will be not passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code you linked to does not affect the processing of required / not required fields. That is controlled by the bidder params json schema, here for Attekmi and the Addigi alias.:
Looking at the base adapter code, it seems the partnerName was only used for a host macro. The host macro was removed (thank you), but the requirement remains.
the value of partnerName will be substituted from the code
No such code exists in the adapter.
If this is the desired behavior, could you please update for adapter code?
🏷 Type of documentation
📋 Checklist
Related pull requests in prebid.js or server are linked ->
Prebid.js PR: Attekmi: add Addigi alias Prebid.js#12697
Prebid server PR: New Adapter: Addigi - Attekmi (SmartHub) Alias prebid-server#4176
For new adapters check submitting your adapter docs