Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attekmi: add Addigi adapter #5836

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SmartHubSolutions
Copy link
Contributor

@SmartHubSolutions SmartHubSolutions commented Jan 28, 2025

🏷 Type of documentation

  • new bid adapter

📋 Checklist

Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 4ca1787
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67ac7bf3e1a18200080dba37
😎 Deploy Preview https://deploy-preview-5836--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

dev-docs/bidders/addigi.md Outdated Show resolved Hide resolved
dev-docs/bidders/addigi.md Show resolved Hide resolved
| Name | Scope | Description | Example | Type |
|---------------|----------|---------------------|--------------------------------------|----------|
| `seat` | required | Seat value | `'9Q20EdGxzgWdfPYShScl'` | `string` |
| `token` | required | Token | `'eKmw6alpP3zWQhRCe3flOpz0wpuwRFjW'` | `string` |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adapter being aliased also requires partnerName. Please include that as a required field for Prebid Server Bid Params section.

Copy link
Contributor Author

@SmartHubSolutions SmartHubSolutions Feb 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to use this parameter. We have foreseen this case.
When the partner will use this adapter, the value of partnerName will be substituted from the code, this should work on Prebid.js and Prebid-server sides

prebid.js will be work correct if partnerName will be not passed

not required on prebid-server

url of alias not uses partnerName

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not required on prebid-server

The code you linked to does not affect the processing of required / not required fields. That is controlled by the bidder params json schema, here for Attekmi and the Addigi alias.:

https://github.com/prebid/prebid-server/blob/1b34580a44b367cd2b00a71c8db6bb69713e2a81/static/bidder-params/smarthub.json#L24

Looking at the base adapter code, it seems the partnerName was only used for a host macro. The host macro was removed (thank you), but the requirement remains.

the value of partnerName will be substituted from the code

No such code exists in the adapter.

If this is the desired behavior, could you please update for adapter code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants