Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adaptivity calling for explicit coupling #145

Merged
merged 8 commits into from
Feb 3, 2025

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Feb 3, 2025

Adaptivity can be computed either once in a time window, or once in every time iteration. For explicit coupling scenarios, these two cases are one and the same. The current logic did not reflect this and hence adaptivity was incorrectly computed for explicit coupling scenarios. This PR fixes the problem.

Checklist:

  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai self-assigned this Feb 3, 2025
@IshaanDesai IshaanDesai added the bug Something isn't working label Feb 3, 2025
@IshaanDesai IshaanDesai merged commit 424bd9d into develop Feb 3, 2025
10 checks passed
@IshaanDesai IshaanDesai deleted the fix-explicit-coupling branch February 3, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant