-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consistently set encoding=utf-8
for opening files
#69
Conversation
I don't know what changed in windows-land (I had thought at first that it was triggered by a local change on my machine), but this is now actually breaking CI - after a passing run, the output validation runs into:
|
Does this actually fix things? utf8 should be the default afaik since a while ... |
Nope, it'll only be the default in python 3.15 (edit: see PEP686). I've also linked a PR with CI broken due to this. |
Yes; I'm carrying the fixes from this PR in my local environment, otherwise I wouldn't be able to rerender the linked PR. |
Do you need a release then? |
That would be great yes! For my personal use I could work around it, but it's not great that this causes CI failures (--> IMO urgent). |
hey! let me make a release |
Companion to conda-forge/conda-smithy#2244; necessary to rerender rattler recipes on windows.