feat: Add S3 upload #1299
Merged
feat: Add S3 upload #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delsner
commented
Jan 22, 2025
|
Sorry, we merged some rather large refactor in #1371 and now this one has a few conflicts. I'll try to get Bas to start merging S3 support in rattler tomorrow and then we can hopefully get the rest in swiftly as well! |
pavelzw
reviewed
Jan 31, 2025
delsner
commented
Feb 15, 2025
pavelzw
reviewed
Feb 15, 2025
|
Looks good to me. Shoudl we remove the TODO comment annd merge? |
|
Let's go! :) |
|
Now we also need OCI upload! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
rattler-buildpart of conda/rattler#960Changes
rattler-build