Update to PHP 8 #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change, as well as requiring the PHP version requirement to be updated, also required newer versions of some of the development and deployment packages to be upgraded too.
With the upgrade to PHP 8 was the upgraded PHPUnit version. The old version of the PHPUnit configuration file had some outdated elements/attributes that the newest version doesn't support. Given that, the configuration file was updated using phpunit.
While attempting to run the tests, testGetForecast consistently failed, with the exception's error message saying that the BOM API had detected the use of automation software during the request. Given that, and that it may well not be necessary to actually make a live request, this change updates the test to use a mock response with one of the fixture files instead. It also improves the performance of the test.
kimpepper
requested changes
Jan 12, 2024
tests/Functional/BomClientTest.php
Outdated
There was a problem hiding this comment.
Can you split out the changes to testGetForecast into a separate PR?
This reverts commit e47e44f. I'm reverting it to move it to a new PR, as requested by @kimpepper.
|
I'll fix the build errors this weekend. |
|
This is outdated now as PHP 8.1+ is supported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR designed to update the project to support the 8.0 release of PHP. It primarily updates composer.json so that the required packages work with the newer release. It also refactors a test which was failing.