Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COST-5623] Add support for GCP daily flow #539

Merged
merged 7 commits into from
Feb 20, 2025
Merged

Conversation

esebesto
Copy link
Contributor

@esebesto esebesto commented Feb 14, 2025

COST-5623
This PR adds--gcp-daily-flow param for GCP to indicate whether the data are ingested as part of the day-to-day flow or not. It affects only json/Bigquery flow:

  • False (default) - no change to existing implementation - existing Bigquery dataset is deleted and new dataset is created for the generated json data
  • True (when the parameter is passed to Nise) - the generated json data are appended to existing Biquery table (instead of deleting existing data first)

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.7%. Comparing base (e1abe83) to head (bff4adb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #539     +/-   ##
=======================================
+ Coverage   93.6%   93.7%   +0.1%     
=======================================
  Files         62      62             
  Lines       4657    4663      +6     
  Branches     645     646      +1     
=======================================
+ Hits        4358    4368     +10     
+ Misses       160     158      -2     
+ Partials     139     137      -2     

@esebesto esebesto force-pushed the esebesto/gcp_daily_2 branch from 0bfab59 to 9f9b29f Compare February 17, 2025 17:17
@esebesto esebesto changed the title DRAFT: [COST-5623] Add support for GCP daily flow [COST-5623] Add support for GCP daily flow Feb 20, 2025
@esebesto esebesto merged commit 5aea935 into main Feb 20, 2025
4 checks passed
@esebesto esebesto deleted the esebesto/gcp_daily_2 branch February 20, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants