Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken mesa dependencies in GeoJupyterViz #269

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

wang-boyu
Copy link
Member

Reproduce #268 which was accidentially closed

@wang-boyu wang-boyu added bug Release notes label dependency Release notes label labels Dec 21, 2024
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.54%. Comparing base (ce501b6) to head (79d04ec).
Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #269      +/-   ##
==========================================
- Coverage   78.21%   73.54%   -4.67%     
==========================================
  Files          10       10              
  Lines         693      858     +165     
  Branches      151      131      -20     
==========================================
+ Hits          542      631      +89     
- Misses        127      194      +67     
- Partials       24       33       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wang-boyu
Copy link
Member Author

With Ewout's approval and mine, I'll go ahead and merge this one. Thanks @AdamZh0u for your contribution on this.

@wang-boyu wang-boyu merged commit 92c869a into projectmesa:main Dec 21, 2024
12 of 13 checks passed
@wang-boyu wang-boyu deleted the pr-268 branch December 21, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release notes label dependency Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant