Private registry support #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code modified introduces the ability for Aspirate commands to handle private registry credentials. This includes new fields in the AspirateState, related options, and a new action for prompting credentials information to users. Updates were also made to interface and variable name references across the files. Still needs to be rolled out into final manifest processor.
Updated various resource processors and manifest related classes to support private Docker registries. Changes include adding new arguments to methods, modifying templates to include image pull secrets, and creating necessary manifests.
This update refactors the options for handling private registries, renaming RegistryUsername/Password/Email to PrivateRegistryURL/Username/Password/Email. The templating logic for generating manifest files has been updated accordingly, with the addition of imagePullSecrets in case private registry is used. Handling of registry credentials in AspirateState has also been updated in accordance with these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.