Groundwork for secrets #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out to be created, then construct the SP Also move the CommandSupport from shared into its own library - shared is getting too crowded
… registered in the DI container
Going to allow to move configuration down a level, and handle merging of commandline arguments with state. Contemplating using IConfiguration to load state and encrypted secrets on command execution, just before serviceProvider is built
…n swap out aspirate configuration now for the state, and persist it to file.
night off tonight, and lots of company work tomorrow so prob 2 days till I can touch on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ground work for secret providers. Will be Implemented this week.
Restructures the solution, and introduces contract interfaces which state must implement so we can ensure options are tracked in state
Makes container registry optional. This will allow docker image store to be used when working locally, and means you can completely skip the
initcommand.As part of this - i've had to introduce a prompt for imagePullPolicy which will be used in the manifests. If you are working with local docker image store, I advise you to choose 'IfNotPresent'