Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor http request code by http-facade #34

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

CennyMo
Copy link
Contributor

@CennyMo CennyMo commented Dec 8, 2024

No description provided.

Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 58.04878% with 86 lines in your changes missing coverage. Please review.

Project coverage is 52.73%. Comparing base (7f741c1) to head (40f8d39).

Files with missing lines Patch % Lines
...thub/protocol/pulsar/admin/jdk/BaseTopicsImpl.java 36.20% 37 Missing ⚠️
...o/github/protocol/pulsar/admin/jdk/Namespaces.java 55.55% 36 Missing ⚠️
...a/io/github/protocol/pulsar/admin/jdk/Tenants.java 47.36% 10 Missing ⚠️
...a/io/github/protocol/pulsar/admin/jdk/Brokers.java 50.00% 0 Missing and 1 partial ⚠️
.../io/github/protocol/pulsar/admin/jdk/Clusters.java 66.66% 1 Missing ⚠️
...hub/protocol/pulsar/admin/jdk/InnerHttpClient.java 97.61% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main      #34      +/-   ##
============================================
- Coverage     57.62%   52.73%   -4.90%     
+ Complexity      101       94       -7     
============================================
  Files            21       21              
  Lines           616      603      -13     
  Branches         57       56       -1     
============================================
- Hits            355      318      -37     
- Misses          209      237      +28     
+ Partials         52       48       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
Signed-off-by: moxiaoying <1159230165@qq.com>
Co-authored-by: ZhangJian He <shoothzj@gmail.com>
@hezhangjian hezhangjian merged commit 59bc219 into protocol-laboratory:main Dec 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants