M600: reduce stack usage #4419
Merged
M600: reduce stack usage #4419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All values in bytes. Δ Delta to base
|
gudnimg
force-pushed
the
reduce-stack-m600-opt
branch
from
a9e5e75 to
7af3e0c
Compare
To handle power panic in M600 we started saving relevant data at the start of M600 gcode. We are currently also saving the same data within gcode_M600 which is saved on the stack. I propose we just use the data already saved in SRAM to reduce stack usage. Change in memory: Flash: -64 bytes SRAM: 0 bytes
gudnimg
force-pushed
the
reduce-stack-m600-opt
branch
from
7af3e0c to
cf0e0f3
Compare
3d-gussner
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To handle power panic in M600 we started saving relevant data at the start of M600 gcode in RAM (starting with 3.13.2). We are currently also saving the same data within
gcode_M600()which is saved on the stack. I propose we just use the data already saved in SRAM to reduce stack usage.Change in memory:
Flash: -64 bytes
SRAM: 0 bytes