-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PFW-1294: Don't attempt to find SD file when recovering USB print #4437
Conversation
All values in bytes. Δ Delta to base
|
4195a39
to
a858bda
Compare
Notes on testing changes to short filename ( https://devblogs.microsoft.com/scripting/use-powershell-to-display-short-file-and-folder-names/ This is my SD card setup (
|
ef34b06
to
d7d7ce1
Compare
If the saved printing type was USB, then EEPROM_FILENAME does not contain anything. The firmware should also not be trying to open a file on a SD card which is maybe not even mounted. Change in memory: Flash: +12 bytes SRAM: 0 bytes
Also removed debug logs
We can just read the whole EEPROM block since short filenames are always null terminated. strcat_P will then apply the file extension at the correct position. Change in memory: Flash: -24 bytes SRAM: 0 bytes
There is no need to read one byte at a time. We can simply read the whole block in one go. This saves some flash memory. Change in memory: Flash: -18 bytes SRAM: 0 bytes
When a SD file is selected to print save the DOS 8.3 extension into EEPROM. After a power outage, the correct file extension is then selected instead of always assuming it's ".gco" This allows users to recover ".g" files. Change in memory: Flash: +104 bytes SRAM: 0 bytes
f61a121
to
dc280b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on MK404
- SD print works as known.
Summary of changes:
.gco
extension was hardcoded, but now.g
will work as well. A new EEPROM entry is addedEEPROM_FILENAME_EXTENSION
TODO: