Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where Load and Unload filament menus may be missing & other related situations #4834

Open
wants to merge 2 commits into
base: MK3
Choose a base branch
from

Conversation

gudnimg
Copy link
Collaborator

@gudnimg gudnimg commented Jan 12, 2025

  • Fix an issue introduced in 3.14.0 where if the filament sensor state machine is in error state, then the Load filament and Unload filament menus wouldn't be shown.
    • This same fix applies in two situations:
    • Nozzle change: detecting if there is filament loaded requires that filament sensor not to be in error state. Previously the firmware would try to use the sensor regardless even though the sensor was toggled OFF in menus.
    • M862: The filament presence check is not executed if the filament sensor is in error condition. Previously if the sensor was in error state, the firmware would try run M862 even though the filament sensor was toggled OFF in menus.
  • The On / Off text in the Filament sensor menu is now using the EEPROM value to check if the sensor is enabled or not.

Fixes #4808

Steps to reproduce:
It is easiest to use PAT9125 sensor.

  1. Disconnect the PAT9125 sensor, such that the firmware will failing reading/writings its registers.
  2. Expected result 1: Both Load and Unload filament menus should be present
  3. Expected result 2: If the filament sensor is toggled OFF in the menus, it will remain OFF through reboots.

isEnabled() returns true if the filament sensor state machine is in error state. In most situations we don't want that.

It is sufficient to check if the filament sensor state machine is in Ready state.
Copy link

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 10 0 247678 5654 6274 2538
MK3_MULTILANG 10 0 247048 5663 6904 2529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] FW 3.14.0 on i3 Mk3 - Filament sensor settings reset after every start of printer
1 participant