Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Firmware_nl.po #4836

Open
wants to merge 1 commit into
base: MK3
Choose a base branch
from
Open

Update Firmware_nl.po #4836

wants to merge 1 commit into from

Conversation

HumbleDeer
Copy link

I updated some of the contextually more relevant phrases,
and got distracted halfway through.

This is basically how far I got by this point.

Some line numbers & remarks/questions:

402 Is ellipsis necessary here?
423 Is ellipsis necessary here?
446 Does the manual come in Dutch? If so, place Dutch chapter/section names here
455 Both EN and NL messaging have different wording compared to 446 (above). Unify?
502 Is ellipsis necessary here?
509 Is ellipsis necessary here?
553 Is ellipsis necessary here?

Questions about ellipsis being necessary relate to the shortened terms (e.g. "Fil.") and/or whether they are required on the screen they are displayed. I don't have a printer to test this on at the moment, unfortunately.

@HumbleDeer
Copy link
Author

I see the run has failed with some length limitations. I suppose those also beg the question, are those limitations of length necessary in that position or the menu where this text is displayed?

Some of the differences in phrasing cause a change in implied action from "Execute this?" to "Executing this already" or the other way around.

@3d-gussner 3d-gussner self-assigned this Jan 20, 2025
@3d-gussner
Copy link
Collaborator

I suppose those also beg the question, are those limitations of length necessary in that position or the menu where this text is displayed?

The messages have a limit in characters and rows you can use depending where the messages are shown.
Example:
MSG_OFF c=3 is used in some toggle menus and as the toggle menu is limited to 18 chars in total you need to ensure that the translations do not exceed this limit.
Other LCD messages are limited to 3 rows as the 4th is used for selections.

In the past we missed some too long translations and the LCD output got bad, that's why the lang check scripts check if these translations are in the defined limits.

@3d-gussner
Copy link
Collaborator

446 Does the manual come in Dutch? If so, place Dutch chapter/section names here

Dutch as some other languages are community made and there are no manuals in Dutch.

@3d-gussner
Copy link
Collaborator

402 Is ellipsis necessary here?
423 Is ellipsis necessary here?
446 Does the manual come in Dutch? If so, place Dutch chapter/section names here
455 Both EN and NL messaging have different wording compared to 446 (above). Unify?
502 Is ellipsis necessary here?
509 Is ellipsis necessary here?
553 Is ellipsis necessary here?

Can you please provide the MSG_ instead of lines as these are different depending on the language.

@3d-gussner
Copy link
Collaborator

In the build check you can see why your PR failed

[E]: Text is longer than definition on line 238: cols=20 rows=1 (rows diff=1)
 source text:
    ₀₁₂₃₄₅₆₇₈₉₀₁₂₃₄₅₆₇₈₉
   |Calibrating home    |
 translated text:
    ₀₁₂₃₄₅₆₇₈₉₀₁₂₃₄₅₆₇₈₉
   |Kalibreren thuisposi|tie

[E]: Text is longer than definition on line 314: cols=20 rows=1 (rows diff=1)
 source text:
    ₀₁₂₃₄₅₆₇₈₉₀₁₂₃₄₅₆₇₈₉
   |Checking endstops   |
 translated text:
    ₀₁₂₃₄₅₆₇₈₉₀₁₂₃₄₅₆₇₈₉
   |Eindstoppers control|eren

[E]: Text is longer than definition on line 319: cols=17 rows=1 (rows diff=1)
 source text:
    ₀₁₂₃₄₅₆₇₈₉₀₁₂₃₄₅₆
   |Checking file    |
 translated text:
    ₀₁₂₃₄₅₆₇₈₉₀₁₂₃₄₅₆
   |Bestand controler|en

[E]: Text is longer than definition on line 549: cols=13 rows=1 (rows diff=1)
 source text:
    ₀₁₂₃₄₅₆₇₈₉₀₁₂
   |F. jam detect|
 translated text:
    ₀₁₂₃₄₅₆₇₈₉₀₁₂
   |F.blok. ontde|k.

@3d-gussner
Copy link
Collaborator

@HumbleDeer Bedankt voor de PR 🇧🇪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants