Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Mistyped Chords Option disallows chained chords if any chord by itself is not in dictionary #220

Open
Mammal4963 opened this issue Oct 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Mammal4963
Copy link

Mammal4963 commented Oct 25, 2024

Describe the bug
Summary:
When the Delete Mistyped Chords Option is enabled - chained chords no longer work as expected.

What happens, and what do you expect to happen instead?
If a chord in a chained chord does not have a standalone chord definition (with the exception of the last chord) then it gets deleted as a mistyped chord and any followup chord entry will not trigger the chained chord output. So for example I can't type Monday using "1 da" because the "1 " does not have a chord definition on it’s own. I expect that because "1 " is a member of a chained chord, it should not be deleted, then if the second chord typed is invalid then everything entered so far should be deleted.

Useful Details

  • Which settings do you have selected in the ZipChord settings?
    Delete Mistyped Chords Option: Enabled

  • If the output is wrong, what is the sequence of keys pressed, the dictionary entry, and what text appears on the screen?
    dictionary entry: "1 da" = Monday
    dictionary entry: "da" = day
    keys pressed: "1 " then "da"
    output to screen: day

Workaround:
As workaround of course I can make dictionary entries for the 1st chords of chained chord definition for all my chained chords, but this results in a lot of chords that exist that I don't actually want to exist on their own. For example I have this saved "ple zr"=pleasure, but to get it to work I first have to save "ple"=ple, because I don't have a need yet for this chord outside of this chained chord definition.

@Mammal4963 Mammal4963 added the bug Something isn't working label Oct 25, 2024
@Mammal4963 Mammal4963 changed the title Delete Mistyped Chords Option disallows chained chords whose first chord is not in dictionary Delete Mistyped Chords Option disallows chained chords if any chord by itself is not in dictionary Oct 25, 2024
@psoukie
Copy link
Owner

psoukie commented Dec 10, 2024

That's a good use case I did not think about. Apologies for responding only now. I've been very busy with my day job, but will look into fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants