Copy files (instead of git clone) on container build #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This recipe would generate the container image from local files, without having to go through github first. The downside is that now the build process is sensitive to the working directory when running singularity build - it needs to be the repositository base dir. This potentially removes the informal role of the GitHub main branch as the "rolling release" of sources for the image. Instead, building files locally becomes easier.
|
Images built from the branch work for me locally. The appveyor CI job seems to work correctly, too (singularity build is called from the base dir, so no changes needed). Given lack of opposition, I will merge this (if anything, there is only one commit to revert). |
ste-phi
pushed a commit
to Aswendt-Lab/inm-icf-utilities
that referenced
this pull request
Sep 10, 2024
Copy files (instead of git clone) on container build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This recipe would generate the container image from local files, without having to go through github first.
The downside is that now the build process is sensitive to the working directory when running singularity build - it needs to be the repositository base dir.
This potentially removes the informal role of the GitHub main branch as the "rolling release" of sources for the image. Instead, building files locally becomes easier.
This should close #54
TODO:
--helpcan be called)