fix: improve testnet start up times in some environments #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SHAcollision , were these files you use to merge all files into a single text file committed intentionally? Switching from 10 to 3 DHTs actually improves test time, ACK for that. |
SHAcollision
force-pushed
the
fix/testnet-startup
branch
from
9454242 to
834520d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the number of Dht testnet nodes from 10 to 3.
Both should suffice for testing. But 3 might improve start up times in some specific environments where
mainline::Testnetafter the5.3.1fix still takes a considerable amount of time to start for some unknown reason. More context in pubky/mainline#52 (comment)