Skip to content

Commit

Permalink
Revert "Implement the setintersection function (#289)"
Browse files Browse the repository at this point in the history
This reverts commit 7741cab.
  • Loading branch information
brandonpollack23 authored Feb 12, 2025
1 parent 7741cab commit 83bf9b9
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 44 deletions.
1 change: 0 additions & 1 deletion CHANGELOG_PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,5 @@
- Implement `distinct` through the `pulumi-std` invoke of the same name
- Implement `format` through the `pulumi-std` invoke of the same name
- Implement `keys` through the `pulumi-std` invoke of the same name
- Implement `setintersection` through the `pulumi-std` invoke of the same name

### Bug Fixes
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
"warning:builtin_functions/main.tf:757,18-57:Function not yet implemented:Function regexall not yet implemented, see pulumi/pulumi-converter-terraform#191",
"warning:builtin_functions/main.tf:760,18-49:Function not yet implemented:Function regexall not yet implemented, see pulumi/pulumi-converter-terraform#191",
"warning:builtin_functions/main.tf:775,11-29:Function not yet implemented:Function reverse not yet implemented, see pulumi/pulumi-converter-terraform#65 (catch all bug)",
"warning:builtin_functions/main.tf:799,11-62:Function not yet implemented:Function setintersection not yet implemented, see pulumi/pulumi-converter-terraform#65 (catch all bug)",
"warning:builtin_functions/main.tf:805,11-67:Function not yet implemented:Function setproduct not yet implemented, see pulumi/pulumi-converter-terraform#65 (catch all bug)",
"warning:builtin_functions/main.tf:808,11-35:Function not yet implemented:Function setproduct not yet implemented, see pulumi/pulumi-converter-terraform#65 (catch all bug)",
"warning:builtin_functions/main.tf:811,11-58:Function not yet implemented:Function setproduct not yet implemented, see pulumi/pulumi-converter-terraform#65 (catch all bug)",
Expand Down
4 changes: 1 addition & 3 deletions pkg/convert/testdata/programs/builtin_functions/pcl/main.pp
Original file line number Diff line number Diff line change
Expand Up @@ -1202,9 +1202,7 @@

# Examples for setintersection
output "funcSetintersection" {
value = invoke("std:index:setintersection", {
input = [["a", "b"], ["b", "c"], ["b", "d"]]
}).result
value = notImplemented("setintersection([\"a\",\"b\"],[\"b\",\"c\"],[\"b\",\"d\"])")
}


Expand Down
34 changes: 0 additions & 34 deletions pkg/convert/testdata/schemas/std.json
Original file line number Diff line number Diff line change
Expand Up @@ -1785,40 +1785,6 @@
"type": "object"
}
},
"std:index:setintersection": {
"description": "Returns the set of elements that all the input sets have in common.",
"inputs": {
"properties": {
"input": {
"type": "array",
"items": {
"type": "array",
"items": {
"$ref": "pulumi.json#/Any"
}
}
}
},
"type": "object",
"required": [
"input"
]
},
"outputs": {
"properties": {
"result": {
"items": {
"$ref": "pulumi.json#/Any"
},
"type": "array"
}
},
"required": [
"result"
],
"type": "object"
}
},
"std:index:sha1": {
"description": "Returns a hexadecimal representation of the SHA-1 hash of the given string.",
"inputs": {
Expand Down
6 changes: 0 additions & 6 deletions pkg/convert/tf.go
Original file line number Diff line number Diff line change
Expand Up @@ -693,12 +693,6 @@ var tfFunctionStd = map[string]struct {
inputs: []string{"cipherText", "key"},
output: "result",
},
"setintersection": {
token: "std:index:setintersection",
inputs: []string{"input"},
output: "result",
paramArgs: true,
},
"sha1": {
token: "std:index:sha1",
inputs: []string{"input"},
Expand Down

0 comments on commit 83bf9b9

Please sign in to comment.