Test that map keys don't get renamed #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
commented
Jan 29, 2024
| value = { | ||
| CAPS = aResource.result | ||
| camelCase = 1 | ||
| snakeCase = 2 |
There was a problem hiding this comment.
Note that these are still being renamed. Fixing this is a bit more involved. If we just flip the logic to assume things are maps not objects then we end up renaming a lot of { k: v} expressions in TF source code which are then used for object values.
There was a problem hiding this comment.
It is probably fine that output objects are renamed because the type of these becomes are object type from component outputs, not a map.
|
Actually this probably fixes #53 as well. |
|
Sorry, I need to take care of #99 |
Zaid-Ajaj
reviewed
Jan 30, 2024
Frassle
force-pushed
the
fraser/renameMaps
branch
from
ba1a256 to
d1585ea
Compare
|
Tests are unblocked and should now pass with #105 |
Frassle
force-pushed
the
fraser/renameMaps
branch
from
d1585ea to
6e7fcda
Compare
Zaid-Ajaj
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100.
This doesn't fix every rename, there's still cases where we should be leaving keys as is but are renaming them.