Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable flatten #271

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Enable flatten #271

merged 1 commit into from
Feb 4, 2025

Conversation

brandonpollack23
Copy link
Contributor

@brandonpollack23 brandonpollack23 commented Jan 31, 2025 •
edited
Loading

@brandonpollack23 brandonpollack23 changed the title [DRAFT] enable flatten. Enable flatten Jan 31, 2025
@brandonpollack23 brandonpollack23 marked this pull request as ready for review January 31, 2025 15:26
@brandonpollack23 brandonpollack23 requested a review from a team as a code owner January 31, 2025 15:26
Frassle
Frassle requested changes Jan 31, 2025
View reviewed changes
Copy link
Member

@Frassle Frassle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think flatten should be in pulumi-std, you lose all the type information if you go through that invoke (it's just list[any] -> list[any]).

We should probably remove it from std, and then add the pcl intrinsic to go flatten generically.

@brandonpollack23
Copy link
Contributor Author

same thing here as #270 , lists already are list[any], they are not generically typed

@brandonpollack23 brandonpollack23 changed the base branch from main to bpollack/implement_merge February 4, 2025 09:05
@brandonpollack23 brandonpollack23 force-pushed the bpollack/implement_merge branch from fb6f170 to 87347f9 Compare February 4, 2025 13:47
@brandonpollack23 brandonpollack23 force-pushed the bpollack/implement_merge branch from 87347f9 to b8bd1ad Compare February 4, 2025 15:53
@brandonpollack23 brandonpollack23 force-pushed the bpollack/enable_flatten branch 2 times, most recently from f849366 to e91a33f Compare February 4, 2025 16:17
@brandonpollack23 brandonpollack23 force-pushed the bpollack/implement_merge branch from b8bd1ad to 1c2e9f5 Compare February 4, 2025 16:17
Base automatically changed from bpollack/implement_merge to main February 4, 2025 16:28
@brandonpollack23 brandonpollack23 merged commit 5dfc97c into main Feb 4, 2025
5 checks passed
@brandonpollack23 brandonpollack23 deleted the bpollack/enable_flatten branch February 4, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frassle Frassle Frassle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the flatten TF/PCL function Support flatten
2 participants
@brandonpollack23 @Frassle