Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a global.json to specifiy a min sdk #159

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add a global.json to specifiy a min sdk #159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sdk/global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"sdk": {
"version": "7.0.306",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're currently targeting dotnet 6, and that's what CI is running. Can this be set to "6.0.412"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should be able to target net 6 using the net7 sdk

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could but we'd need CI updated to 7 and I think I'd rather test against exactly the minimum version we say we support. We should probably be testing against the latest as well (which we're currently missing), but I'd assume this would be fine if global.json asked for 6 but only the 7 sdk was installed.

"allowPrerelease": true,
"rollForward": "latestFeature"
}
}