Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete on the retainOnDelete resource option #102

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Sep 17, 2024

No description provided.

@iwahbe iwahbe requested a review from a team September 17, 2024 11:06
@iwahbe iwahbe self-assigned this Sep 17, 2024
@iwahbe iwahbe added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Sep 17, 2024
@iwahbe iwahbe force-pushed the iwahbe/add-retainOnDelete-resource-option branch from 6a75b54 to 47fac41 Compare September 17, 2024 11:19
Copy link
Contributor

@lunaris lunaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nit is that maybe we pick another help text for it -- "leak" feels a bit low level. E.g. something in line with/from https://www.pulumi.com/docs/iac/concepts/options/retainondelete/?

@iwahbe iwahbe merged commit 055433f into main Sep 17, 2024
5 checks passed
@iwahbe iwahbe deleted the iwahbe/add-retainOnDelete-resource-option branch September 17, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants