Attempt to fix publishing steps #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The publishing steps in this repository have been broken for a while now, due to a mismatch when extracted artifacts produced by GoReleaser. Specifically, ARM64 artifacts now end up with an appended MIPS version, which for us appears to always be 8.0. It's not clear to me when this mismatch was first introduced, though I suspect it was triggered by some new GoReleaser version being pulled by the action (since we don't pin a version) and has been broken ever since. In this change I've modified the expected filenames (I believe), which I think will fix things, though someone reviewing this may have a better idea/a real solution if this is just symptom curing. > [!NOTE] > It appears that the `alpine` entry has been using ARM64 binaries, > despite being listed as an `x64` architecture, so I've changed this. > Is this correct?
lunaris
added
the
impact/no-changelog-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The publishing steps in this repository have been broken for a while now, due to a mismatch when extracted artifacts produced by GoReleaser. Specifically, ARM64 artifacts now end up with an appended MIPS version, which for us appears to always be 8.0. It's not clear to me when this mismatch was first introduced, though I suspect it was triggered by some new GoReleaser version being pulled by the action (since we don't pin a version) and has been broken ever since. In this change I've modified the expected filenames (I believe), which I think will fix things, though someone reviewing this may have a better idea/a real solution if this is just symptom curing.
Note
It appears that the
alpineentry has been using ARM64 binaries,despite being listed as an
x64architecture, so I've changed this.Is this correct?