Skip to content

Commit

Permalink
fix resource typing requiring lower-case fields and skip checking log…
Browse files Browse the repository at this point in the history
…ical-name example
  • Loading branch information
Zaid-Ajaj committed Jan 18, 2024
1 parent 6393f82 commit b6fb766
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/pulumiyaml/ast/template.go
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ func (d *ResourceDecl) recordSyntax() *syntax.Node {

// The names of exported fields.
func (*ResourceDecl) Fields() []string {
return []string{"type", "logicalName", "defaultprovider", "properties", "options", "get"}
return []string{"type", "logicalname", "defaultprovider", "properties", "options", "get"}
}

func ResourceSyntax(node *syntax.ObjectNode, typ *StringExpr, logicalName *StringExpr, defaultProvider *BooleanExpr,
Expand Down
2 changes: 2 additions & 0 deletions pkg/pulumiyaml/codegen/gen_program_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ func TestGenerateProgram(t *testing.T) {
case "regress-node-12507":
// https://github.com/pulumi/pulumi-yaml/issues/494
case "config-variables":
case "logical-name":
// Needs config set in order to compile/run.
tt.SkipCompile = codegen.NewStringSet("yaml")
l = append(l, tt)
Expand All @@ -216,6 +217,7 @@ func TestGenerateProgram(t *testing.T) {
assert.NoError(t, err)
assert.Falsef(t, diags.HasErrors(), "%s", diags.Error())
err = pulumi.RunErr(func(ctx *pulumi.Context) error {

return pulumiyaml.RunTemplate(ctx, templateDecl, nil, nil, testPackageLoader{t})
}, pulumi.WithMocks("test", "gen", &testMonitor{}), func(ri *pulumi.RunInfo) { ri.DryRun = true })
assert.NoError(t, err)
Expand Down

0 comments on commit b6fb766

Please sign in to comment.