Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip invalid YAML when detecting packages #666

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Skip invalid YAML when detecting packages #666

merged 2 commits into from
Oct 29, 2024

Conversation

blampe
Copy link
Contributor

@blampe blampe commented Oct 29, 2024 •
edited
Loading

The Kubernetes provider can't currently upgrade to 3.137 because it has YAML test programs which co-exist with some Helm chart templates.

stderr: error: failed to discover plugin requirements: : searching . for package declarations: unmarshalling helmExample/charts/mychart/templates/serviceaccount.yaml: yaml: did not find expected node content;

These templates aren't valid YAML, but they shouldn't cause package detection to fail.

Refs pulumi/pulumi-kubernetes#3286.

Fixes #665.

@blampe blampe requested a review from a team as a code owner October 29, 2024 20:58
@blampe blampe mentioned this pull request Oct 29, 2024
Closed
justinvp
justinvp approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise. Thanks!

@blampe blampe force-pushed the blampe/ignore-invalid-yaml branch from 0bb6e15 to 8e26c02 Compare October 29, 2024 22:28
@blampe blampe merged commit eed2fe4 into main Oct 29, 2024
6 checks passed
@blampe blampe deleted the blampe/ignore-invalid-yaml branch October 29, 2024 22:37
@justinvp justinvp mentioned this pull request Oct 29, 2024
Merged
justinvp added a commit that referenced this pull request Oct 29, 2024
@justinvp
Changelog for v1.11.2 (#667)
881de9d 
## v1.11.2 - 2024-10-29

### Bug Fixes

- [runtime] Fix potential panic when using fn::secret on a resource
[#664](#664)

- [runtime] Invalid YAML files no longer cause package detection to
fail. [#666](#666)
@pulumi-bot
Copy link

This PR has been shipped in release v1.11.2.

@pulumi-bot pulumi-bot mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

Assignees

@blampe blampe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect assumption that any nested yaml file is a package configuration
3 participants
@blampe @pulumi-bot @justinvp