Turn on more tests, record remaining failures #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
added
the
impact/no-changelog-required
tgummerer
reviewed
Nov 15, 2024
| "l2-invoke-options": "cannot assign expression", | ||
| "l2-map-keys": "missing expected dependency primitive", | ||
| "l2-provider-grpc-config-schema-secret": "Detected a secret leak in state", | ||
| "l2-invoke-secrets": "YAML does not support fn::secret", |
There was a problem hiding this comment.
What does this mean? YAML has a fn::secret here:
pulumi-yaml/pkg/pulumiyaml/ast/expr.go
Line 782 in 430fa60
There was a problem hiding this comment.
That's just the error message I got when running this test, I didn't dig into it deeper.
tgummerer
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns on the remaining already passing conformance tests for YAML, and records a reason why the remaining failing tests are failing.