Enable l2-resource-asset-archive test #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frassle
force-pushed
the
fraser/l2-ass
branch
3 times, most recently
from
b50c32a to
a2015af
Compare
Frassle
force-pushed
the
fraser/l2-ass
branch
from
a2015af to
cdc7aa9
Compare
tgummerer
approved these changes
Nov 18, 2024
| runtime: yaml | ||
| outputs: | ||
| readme: | ||
| fn::readFile: ${pulumi.cwd}/../../go.mod # imagine this is /etc/shadow, /var/run/secrets/tokens, etc. |
There was a problem hiding this comment.
This made me pause for a second, as it's security related. I don't think it's in our security model to guard against users doing anything in their programs in general though (that would be really hard to do in other supported languages anyway). The user running the program needs to be the one to inspect and trust it, so I think removing this restriction is fine.
Co-authored-by: Thomas Gummerer <t.gummerer@gmail.com>
|
This PR has been shipped in release v1.12.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit more of an involved change to get this test working. Making two major changes.
Firstly, historically YAML would always send absolute paths instead of relative paths to the engine. This was wrong, the engine expects that paths should be relative so that we don't save absolute paths to the state file.
Secondly, YAML would error if you tried to access what it considered "unsafe" paths. That was either paths that clearly accessed outside the Pulumi.yaml directory, or non-constant paths to the remote asset and archive types. This seems overly restrictive, none of our other languages try to protect the user like this and it seems reasonable to expect to be able to do similar filesystem accesses from YAML.