Remove insecure pe_installer_source parameter

[bastelfreak]

Summary

As discussed in an earlier meeting, #465 was closed because the security team demands that peadm doesn't support downloading from provided URLs and the pe_installer_source parameter has to go away.

Additional Context

Add any additional context about the problem here.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

• 🟢 Spec tests.
• 🟢 Acceptance tests.

Changes include test coverage?

• Yes
• Not needed

Have you updated the documentation?

• Yes, I've updated the appropriate docs
• Not needed

[bastelfreak]

Before merging #524, could you please merge and release #523 & #459 ?

[bastelfreak]

@ragingra any chance this can finally be reviewed and merged?

[GSPatton]

Hi @bastelfreak. After reviewing this PR with the team, we have concluded that this is not something we would be willing to merge as this will induce breaking changes. As always, we appreciate your contribution and valued input.

Thanks,
Gavin

[bastelfreak]

Sorry, but are you joking?
Both of us and your security team had a meeting. The security team declined #465 because it was insecure from their point of view. They demanded that the pe_installer_source parameter gets removed. And now, after months, you finally respond but just close it? Did the security team change their mind? Does that mean #465 will now be merged?

As always, we appreciate your contribution and valued input.

Sorry, but it doesn't feel like that.