(maint) pdk 340 update #555
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to stricter YAML parsing rules in Ruby 3.2.5 (used by PDK 3.4.0), unquoted Ruby symbols in .sync.yml cause parsing errors. This updates all Ruby symbols to be properly quoted strings (e.g. ':development' instead of :development). The error encountered was: ```bash Psych::DisallowedClass: Tried to load unspecified class: Symbol from psych/class_loader.rb:99:in `find' ``` This change allows the module to be properly updated using PDK 3.4.0 while maintaining the same functionality. Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
gavindidrichsen
force-pushed
the
pdk_340_update
branch
2 times, most recently
from
83bf28e to
075d946
Compare
Updates the module to PDK 3.4.0 with minimal changes: - Updates gem dependencies for Ruby 3.x compatibility - Updates CI workflow configuration - All unit tests passing with 6 expected pending tests - No functional changes to module code
gavindidrichsen
force-pushed
the
pdk_340_update
branch
from
18a0f18 to
553aeff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PDK to 3.4.0
Summary
This PR updates the module from PDK 3.0.0 to PDK 3.4.0 with minimal, non-intrusive changes. The update includes necessary fixes for Ruby 3.2.5 compatibility, particularly around YAML symbol parsing.
Changes
.sync.yml.vscodeto.gitignoreto prevent IDE-specific files from being trackedTesting
Note
The 6 pending tests are expected and are related to Bolt functionality that requires special handling in the test environment. These were present before this update and are not affected by these changes.