Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) add support for private gem source authentication #556

Draft
wants to merge 8 commits into
base: pdk_340_update
Choose a base branch
from

Conversation

gavindidrichsen
Copy link

(feat) Add support for private gem source authentication

Updates the module to use the auth_token_template branch which adds support
for authenticating against private gem sources. This change:

  • Updates Gemfile to conditionally use private gem source when PUPPET_AUTH_TOKEN
    is present
  • Only applies private source to puppet-related gems (puppet, facter)
  • Falls back to rubygems.org when PUPPET_AUTH_TOKEN is not set
  • Updates template references to use the add_gem_switch_for_auth_token branch

This change enables the module to fetch gems from private sources when
appropriate credentials are provided, while maintaining compatibility with
public sources by default.

@gavindidrichsen gavindidrichsen force-pushed the auth_token_template branch 2 times, most recently from fbe8543 to a854970 Compare February 28, 2025 08:57
gavindidrichsen and others added 8 commits February 28, 2025 11:45
Updates the module to PDK 3.4.0 with minimal changes:
- Updates gem dependencies for Ruby 3.x compatibility
- Updates CI workflow configuration
- All unit tests passing with 6 expected pending tests
- No functional changes to module code
Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
Updates the module to use the auth_token_template branch which adds
support
for authenticating against private gem sources. This change:

- Updates Gemfile to conditionally use private gem source when
PUPPET_AUTH_TOKEN
  is present
- Only applies private source to puppet-related gems (puppet, facter)
- Falls back to rubygems.org when PUPPET_AUTH_TOKEN is not set
- Updates template references to use the add_gem_switch_for_auth_token
branch

This change enables the module to fetch gems from private sources when
appropriate credentials are provided, while maintaining compatibility
with
public sources by default.

Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
Updates Ruby version to 3.2.5 to match PDK 3.4.0 requirements.
All unit tests passing with this version (100 examples, 0 failures, 6 expected pending).

Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
Signed-off-by: Gavin Didrichsen <gavin.didrichsen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant