rename

pwncollege · Nov 13, 2024 · 8c4ca26 · 8c4ca26
1 parent 710a9e3
commit 8c4ca26
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/example_module/__init__.py b/example_module/__init__.py
@@ -62,5 +62,5 @@ class Shell1604(ShellExample):
     """
 
     BUILD_IMAGE = "pwncollege/pwnshop-builder:ubuntu1604"
-    BUILD_DEPENDENCIES = "libcapstone-dev"
+    BUILD_DEPENDENCIES = [ "libcapstone-dev" ]
     PIN_LIBRARIES = True
diff --git a/pwnshop/challenge.py b/pwnshop/challenge.py
@@ -57,9 +57,10 @@ class Challenge:
     EXEC_STACK = False
     STRIP = False
     DEBUG_SYMBOLS = False
-    LINK_LIBRARIES = []
+
     BUILD_IMAGE = None
-    BUILD_DEPENDENCIES = ""
+    BUILD_DEPENDENCIES = []
+    LINK_LIBRARIES = []
     PIN_LIBRARIES = False
 
 
@@ -315,7 +316,7 @@ def _containerized_build(self, cmd):
             detach=True,
             volumes = {self.work_dir : {'bind': self.work_dir, 'mode': 'rw'}}
         )
-        ret, out = container.exec_run(f'/bin/bash -c "apt-get update && apt-get install -y gcc patchelf {self.BUILD_DEPENDENCIES} && mkdir -p /tmp/pwnshop"')
+        ret, out = container.exec_run(f'/bin/bash -c "apt-get update && apt-get install -y gcc patchelf {" ".join(self.BUILD_DEPENDENCIES)} && mkdir -p /tmp/pwnshop"')
         if ret != 0:
             print("DEPENDENCY INSTALL ERROR:")
             print(out.decode('latin1'))