Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: dataclass InitVars shouldn't be required on serialization #1602

Merged
merged 14 commits into from
Jan 23, 2025
6 changes: 4 additions & 2 deletions src/serializers/type_serializers/dataclass.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,16 +42,18 @@ impl BuildSerializer for DataclassArgsBuilder {
let name: String = field_info.get_as_req(intern!(py, "name"))?;

let key_py: Py<PyString> = PyString::new(py, &name).into();
let init_only = field_info.get_as(intern!(py, "init_only"))?.unwrap_or(false);
let required = !init_only;

if field_info.get_as(intern!(py, "serialization_exclude"))? == Some(true) {
fields.insert(name, SerField::new(py, key_py, None, None, true));
fields.insert(name, SerField::new(py, key_py, None, None, required));
} else {
let schema = field_info.get_as_req(intern!(py, "schema"))?;
let serializer = CombinedSerializer::build(&schema, config, definitions)
.map_err(|e| py_schema_error_type!("Field `{}`:\n {}", index, e))?;

let alias = field_info.get_as(intern!(py, "serialization_alias"))?;
fields.insert(name, SerField::new(py, key_py, alias, Some(serializer), true));
fields.insert(name, SerField::new(py, key_py, alias, Some(serializer), required));
}
}

Expand Down
Loading