Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always use maturin for the uv commands in Makefile #1622

Merged
merged 2 commits into from
Feb 5, 2025
Merged

always use maturin for the uv commands in Makefile #1622

merged 2 commits into from
Feb 5, 2025

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Since we moved to uv we can guarantee that maturin should be properly installed in the venv, so this should be fine to run like this.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@davidhewitt davidhewitt added the Full Build cause CI to do a full build label Feb 5, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 5, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #1622 will not alter performance

Comparing dh/uv-run-maturin (e8c5b46) with main (ed15f6c)

Summary

✅ 157 untouched benchmarks

@davidhewitt davidhewitt merged commit fdccecd into main Feb 5, 2025
60 checks passed
@davidhewitt davidhewitt deleted the dh/uv-run-maturin branch February 5, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
Full Build cause CI to do a full build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidhewitt @sydney-runkle