Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor LookupKey logic to reduce redundancy #1635

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Precursor to #1620, which is itself a precursor to moving forward with pydantic/jiter#184

The idea here is that the LookupPath stuff contains a bunch of redundant String and Py<PyString> values. I work these away.

I also removed Clone implementation at the same time, which gets us closer to removing PyO3's py-clone feature.

Related issue number

N/A

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

Copy link

codspeed-hq bot commented Feb 13, 2025

CodSpeed Performance Report

Merging #1635 will not alter performance

Comparing dh/lookup-path-refactor (d6938ef) with main (7da4798)

Summary

✅ 157 untouched benchmarks

@davidhewitt
Copy link
Contributor Author

Integration test failure is due to #1585, so not a concern.

Given there are no perf concerns nor behavioural changes, I'm just going to merge this and move on.

@davidhewitt davidhewitt merged commit 741961c into main Feb 13, 2025
28 of 29 checks passed
@davidhewitt davidhewitt deleted the dh/lookup-path-refactor branch February 13, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant